add camera GetProperties #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniels
requested review from
njooma and
purplenicole730
and removed request for
a team
njooma
reviewed
Apr 11, 2024
| @@ -50,7 +54,15 @@ public static Camera fromRobot(final RobotClient robot, final String name) { | |||
| public abstract Image getImage(final Format format, | |||
| final Optional<Struct> extra); | |||
|
|
|||
| public abstract Entry<List<Image>, Common.ResponseMetadata> getImages(); | |||
| public Entry<List<Image>, Common.ResponseMetadata> getImages() { | |||
There was a problem hiding this comment.
[q] why provide a default implementation here?
There was a problem hiding this comment.
Just want to point out that this could be a subtle point of bugs for anyone expecting getImages to work, but a camera implementer didn't provide it. This doesn't provide the user with any feedback (like an unimplemented error)
There was a problem hiding this comment.
eh yeah. ill change it back.
njooma
previously approved these changes
Apr 11, 2024
|
@edaniels can you revert or can we close this? |
njooma
dismissed stale reviews from purplenicole730 and themself
No longer approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.